[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1d052b98-4dfd-4ee3-b46f-ac043b406d58@oss.qualcomm.com>
Date: Tue, 7 Oct 2025 13:42:15 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Ram Prakash Gupta <quic_rampraka@...cinc.com>,
Rob Herring <robh@...nel.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, linux-mmc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, dmitry.baryshkov@....qualcomm.com,
quic_pragalla@...cinc.com, quic_sayalil@...cinc.com,
quic_nitirawa@...cinc.com, quic_bhaskarv@...cinc.com,
kernel@....qualcomm.com, Sachin Gupta <quic_sachgupt@...cinc.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: mmc: Add dll-hsr-list for HS400 and
HS200 modes
On 10/7/25 1:16 PM, Ram Prakash Gupta wrote:
>
> On 10/7/2025 3:18 AM, Rob Herring wrote:
>> On Mon, Sep 29, 2025 at 05:05:12PM +0530, Ram Prakash Gupta wrote:
>>> From: Sachin Gupta <quic_sachgupt@...cinc.com>
>>>
>>> Document the 'dll-hsr-list' property for MMC device tree bindings.
>>> The 'dll-hsr-list' property defines the DLL configurations for HS400
>>> and HS200 modes.
>>>
>>> QC SoCs can have 0 to 4 SDHCI instances, and each one may need
>>> different tuning.
>>>
>>> Signed-off-by: Sachin Gupta <quic_sachgupt@...cinc.com>
>>> Signed-off-by: Ram Prakash Gupta <quic_rampraka@...cinc.com>
>>> ---
>>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> index 22d1f50c3fd1..a60222473990 100644
>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> @@ -137,6 +137,11 @@ properties:
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>> description: platform specific settings for DLL_CONFIG reg.
>>>
>>> + qcom,dll-hsr-list:
>> '-list' doesn't add anything.
>
> list was used as there are 5 dll register, but '-list' can be
> dropped, and it can be renamed to qcom,dll-hsr, I will update in
> next patchset.
>
>>
>> What is 'hsr'?
>
> Hardware Settings Reference
Maybe "qcom,dll-presets" would be more clear?
Konrad
Powered by blists - more mailing lists