[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b6223af9-2d9e-4ccd-b297-79f63167242b@oss.qualcomm.com>
Date: Tue, 7 Oct 2025 14:39:21 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Alexey Klimov <alexey.klimov@...aro.org>,
Bjorn Andersson <andersson@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Srinivas Kandagatla <srini@...nel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-sound@...r.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin
controller
On 10/7/25 4:03 AM, Alexey Klimov wrote:
> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin
> controller device node required for audio subsystem on Qualcomm
> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115.
>
> While at this, also add description of lpi_i2s2 pins (active state)
> required for audio playback via HDMI/I2S.
>
> Cc: Srinivas Kandagatla <srini@...nel.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
[...]
> + lpi_i2s2_active: lpi-i2s2-active-state {
> + data-pins {
> + pins = "gpio12";
> + function = "i2s2_data";
> + bias-disable;
> + drive-strength = <8>;
> + output-high;
I.. doubt output-high is what you want?
> + };
> +
> + sck-pins {
> + pins = "gpio10";
> + function = "i2s2_clk";
> + bias-disable;
> + drive-strength = <8>;
> + output-high;
> + };
> +
> + ws-pins {
> + pins = "gpio11";
Please re-sort pin entries by the gpio index
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
Konrad
Powered by blists - more mailing lists