[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAN7C2SCrHwrNjYG6SG_bgGhm4Vuw6z5WeTSO0L0D=yD_GcHuSw@mail.gmail.com>
Date: Tue, 7 Oct 2025 21:54:09 +0800
From: Sune Brian <briansune@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>, Liam Girdwood <lgirdwood@...il.com>,
Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/soc/codecs/wm8978: add missing BCLK divider setup
Mark Brown <broonie@...nel.org> 於 2025年10月7日 週二 下午9:48寫道:
> Systems doing this are using a machine driver written for that specific
> machine and will know exactly which CODEC and other components they are
> dealing with.
With such idea, this is not CODEC controlled from first place to
restrict the possible configurations.
This could introduce many possible hazard, but not this patch trying
to fix from first place.
As for Charles, I will try to patch with option 2 unless it is too
tedious to do so.
I think you have two options:
1) Remove WM8978_BCLKDIV from wm8978_set_dai_clkdiv. There are no
upstream users that I can see, so this should be fine. This
would mean an out of tree user of snd_soc_dai_set_clkdiv would
now get an error so they know they need to fix something.
2) Only run your dynamic BCLK code if wm8978_set_dai_clkdiv
hasn't been called. This would mean any out of tree users of
snd_soc_dai_set_clkdiv would have no problems everything would
keep working as before, but at the cost of a little complexity
in the code.
Powered by blists - more mailing lists