linux-kernel - Re: [PATCH V1 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300 DMA engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <734de17e-a712-4eb5-96fa-b7e75f86d880@kernel.org>
Date: Tue, 7 Oct 2025 23:27:12 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: CL Wang <cl634@...estech.com>, Conor Dooley <conor@...nel.org>
Cc: vkoul@...nel.org, dmaengine@...r.kernel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, tim609@...estech.com
Subject: Re: [PATCH V1 1/2] dt-bindings: dmaengine: Add support for ATCDMAC300
 DMA engine

On 07/10/2025 21:33, CL Wang wrote:
> Hi Conor,
> 
> Thanks for your review.
> 
> Yes, the DMA driver supports the Qilai platform. I have updated the DTS binding as shown below.  
> Could you please take a look and let me know if anything still needs to be adjusted?
> 
>  properties:
>    compatible:
> -    const: andestech,atcdmac300
> +    oneOf:
> +      - items:
> +          - enum:
> +              - andestech,qilai-dma
> +          - const: andestech,atcdmac300
> +      - const: andestech,atcdmac300
> ...
>          dma-controller@...00000 {
> -            compatible = "andestech,atcdmac300";
> +            compatible = "andestech,qilai-dma", "andestech,atcdmac300";

What is "atcdmac300" then? Usually the recommendation is to go only with
soc-based compatibles, not IP blocks. See also:

https://elixir.bootlin.com/linux/v6.17.1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42

Best regards,
Krzysztof