linux-kernel - Re: [PATCH v3] ASoC: wm8978: add missing BCLK divider setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN7C2SDUiuMfPs_X5r0RDC56313aJsfhfx0-juhZRKGTb1OKuA@mail.gmail.com>
Date: Tue, 7 Oct 2025 23:55:29 +0800
From: Sune Brian <briansune@...il.com>
To: Charles Keepax <ckeepax@...nsource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, linux-sound@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ASoC: wm8978: add missing BCLK divider setup

Charles Keepax <ckeepax@...nsource.cirrus.com> 於 2025年10月7日 週二 下午11:21寫道：

> Apologies but just realised there is still one small problem here.
> You want to match the closest BCLK that is over your target rate,
> if the BCLK is too slow the system won't work. As your bclk_divs
> array is sorted I think you can do something like:
>
>         for (i = 0; i < ARRAY_SIZE(bclk_divs); i++) {
>                 bclk = wm8978->f_256fs / bclk_divs[i];
>
>                 if (bclk < target_bclk)
>                         break;
>
>                 bclkdiv = i;
>         }
>
> Thanks,
> Charles

Not too understand what is the issue.
The idea is setting the initial value to max any diff that is smaller
will update bclkdiv index,
If the maximum LUT 32 still not met then it is what it is.
mclk / 32 is the bclk, unless you want an error message.

Charles Keepax <ckeepax@...nsource.cirrus.com> 於 2025年10月7日 週二 下午11:21寫道：
>
> On Tue, Oct 07, 2025 at 10:50:28PM +0800, Brian Sune wrote:
> > In previous WM8978 codec driver versions, wm8978_set_dai_clkdiv
> > might not have been called for BCLK, leaving the bit clock
> > divider unconfigured. This could cause incorrect or unstable audio
> > clocks depending on sample rate and word length.
> >
> > This patch adds a check in wm8978_hw_params: if the BCLK divider
> > has not been set via wm8978_set_dai_clkdiv, it is dynamically
> > calculated and configured at runtime.
> >
> > This ensures that BCLK is always correctly set, whether the
> > machine driver configures it explicitly or not.
> >
> > Signed-off-by: Brian Sune <briansune@...il.com>
> > ---
> >  sound/soc/codecs/wm8978.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c
> > index 8c45ba6fc4c3..8dfce6ede8cd 100644
> > --- a/sound/soc/codecs/wm8978.c
> > +++ b/sound/soc/codecs/wm8978.c
> > @@ -99,6 +99,7 @@ struct wm8978_priv {
> >       unsigned int f_mclk;
> >       unsigned int f_256fs;
> >       unsigned int f_opclk;
> > +     bool bclk_set;
> >       int mclk_idx;
> >       enum wm8978_sysclk_src sysclk;
> >  };
> > @@ -590,6 +591,7 @@ static int wm8978_set_dai_clkdiv(struct snd_soc_dai *codec_dai,
> >       case WM8978_BCLKDIV:
> >               if (div & ~0x1c)
> >                       return -EINVAL;
> > +             wm8978->bclk_set = true;
> >               snd_soc_component_update_bits(component, WM8978_CLOCKING, 0x1c, div);
> >               break;
> >       default:
> > @@ -717,6 +719,11 @@ static int wm8978_hw_params(struct snd_pcm_substream *substream,
> >                           struct snd_pcm_hw_params *params,
> >                           struct snd_soc_dai *dai)
> >  {
> > +     unsigned int bclk, bclkdiv = 0, min_diff = UINT_MAX;
> > +     unsigned int target_bclk = params_rate(params) * params_width(params) * 2;
> > +     /* WM8978 supports divisors */
> > +     static const int bclk_divs[] = {1, 2, 4, 8, 16, 32};
> > +
> >       struct snd_soc_component *component = dai->component;
> >       struct wm8978_priv *wm8978 = snd_soc_component_get_drvdata(component);
> >       /* Word length mask = 0x60 */
> > @@ -820,6 +827,23 @@ static int wm8978_hw_params(struct snd_pcm_substream *substream,
> >       /* MCLK divisor mask = 0xe0 */
> >       snd_soc_component_update_bits(component, WM8978_CLOCKING, 0xe0, best << 5);
> >
> > +     if (!wm8978->bclk_set) {
>
> Yeah that looks good.
>
> > +             for (i = 0; i < ARRAY_SIZE(bclk_divs); i++) {
> > +                     bclk = wm8978->f_256fs / bclk_divs[i];
> > +                     if (abs(bclk - target_bclk) < min_diff) {
> > +                             min_diff = abs(bclk - target_bclk);
> > +                             bclkdiv = i;
> > +                     }
> > +             }
>
> Apologies but just realised there is still one small problem here.
> You want to match the closest BCLK that is over your target rate,
> if the BCLK is too slow the system won't work. As your bclk_divs
> array is sorted I think you can do something like:
>
>         for (i = 0; i < ARRAY_SIZE(bclk_divs); i++) {
>                 bclk = wm8978->f_256fs / bclk_divs[i];
>
>                 if (bclk < target_bclk)
>                         break;
>
>                 bclkdiv = i;
>         }
>
> Thanks,
> Charles