linux-kernel - Re: [PATCH] smb: client: Move an error code assignment in smb3_init_transform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <99546145-8c6a-4e26-a787-b5c9bb0b8613@web.de>
Date: Wed, 8 Oct 2025 23:00:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Steve French <smfrench@...il.com>,
 Henrique Carvalho <henrique.carvalho@...e.com>, linux-cifs@...r.kernel.org,
 samba-technical <samba-technical@...ts.samba.org>,
 Bharath SM <bharathsm@...rosoft.com>, Paulo Alcantara <pc@...guebit.org>,
 Pavel Shilovsky <pshilov@...rosoft.com>,
 Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N <sprasad@...rosoft.com>, Steve French <sfrench@...ba.org>,
 Tom Talpey <tom@...pey.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] smb: client: Move an error code assignment in
 smb3_init_transform_rq()

> Also when a patch doesn't shrink code, but even grows it by one line, and doesn't make it much clearer, it is probably not worth changing (it complicates future backports of real fixes in the future eg). Let's limit these to those that shrink code and make code clearer (or ideally fix potential bugs)

Do you insist to keep an extra initialisation for the local variable “rc”
despite of the implementation detail that the value “-ENOMEM” is needed
only for a single if branch here?

Regards,
Markus