[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <w54im5c6zbeoik44jrzvwnfrcxpbf3pzke74a7r4kcgq6balvh@d33v6xpmua6s>
Date: Thu, 9 Oct 2025 00:40:02 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Yongbang Shi <shiyongbang@...wei.com>
Cc: xinliang.liu@...aro.org, tiantao6@...ilicon.com,
maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
kong.kongxinwei@...ilicon.com, liangjian010@...wei.com,
chenjianmin@...wei.com, fengsheng5@...wei.com, libaihan@...wei.com,
shenjian15@...wei.com, shaojijie@...wei.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 drm-dp 1/4] drm/hisilicon/hibmc: fix dp
probabilistical detect errors after HPD irq
On Fri, Sep 26, 2025 at 09:14:57AM +0800, Yongbang Shi wrote:
> From: Baihan Li <libaihan@...wei.com>
>
> The issue is that drm_connector_helper_detect_from_ddc() returns wrong
> status when plugging or unplugging the monitor. Use HPD pin status in
> DP's detect_ctx() for real physcal monitor in/out, and implementation
> a complete DP detection including read DPCD, check if it's a branch
> device and its sink count for different situations.
>
> Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature")
> Signed-off-by: Baihan Li <libaihan@...wei.com>
> Signed-off-by: Yongbang Shi <shiyongbang@...wei.com>
> ---
> ChangeLog:
> v7 -> v8:
> - fix build errors reported by kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509241625.o4mNleVb-lkp@intel.com/
> v6 -> v7:
> - add the check about branch devices, suggested by Dmitry Baryshkov.
> v5 -> v6:
> - use HPD status in DP detect_ctx(), suggested by Dmitry Baryshkov.
> v4 -> v5:
> - fix the commit message and DP detect_ctx(), suggested by Dmitry Baryshkov.
> ---
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 4 ++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 12 +++++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 +++
> drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 3 ++
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 48 ++++++++++++++++++-
> 5 files changed, 71 insertions(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
--
With best wishes
Dmitry
Powered by blists - more mailing lists