[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <dc579ed2-05d9-4794-9b05-a6b403d05eaa@amd.com>
Date: Wed, 8 Oct 2025 11:00:21 +0530
From: "Garg, Shivank" <shivankg@....com>
To: Sean Christopherson <seanjc@...gle.com>, Marc Zyngier <maz@...nel.org>,
Oliver Upton <oliver.upton@...ux.dev>, Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
David Hildenbrand <david@...hat.com>, Fuad Tabba <tabba@...gle.com>,
Ackerley Tng <ackerleytng@...gle.com>, Ashish Kalra <ashish.kalra@....com>,
Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH v12 02/12] KVM: guest_memfd: Add macro to iterate over
gmem_files for a mapping/inode
On 10/8/2025 3:44 AM, Sean Christopherson wrote:
> Add a kvm_gmem_for_each_file() to make it more obvious that KVM is
> iterating over guest_memfd _files_, not guest_memfd instances, as could
> be assumed given the name "gmem_list".
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
> virt/kvm/guest_memfd.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c
> index 3c57fb42f12c..9b9e239b3073 100644
> --- a/virt/kvm/guest_memfd.c
> +++ b/virt/kvm/guest_memfd.c
> @@ -22,6 +22,9 @@ struct gmem_file {
> struct list_head entry;
> };
>
> +#define kvm_gmem_for_each_file(f, mapping) \
> + list_for_each_entry(f, &(mapping)->i_private_list, entry)
> +
> /**
> * folio_file_pfn - like folio_file_page, but return a pfn.
> * @folio: The folio which contains this index.
> @@ -159,13 +162,12 @@ static void __kvm_gmem_invalidate_begin(struct gmem_file *f, pgoff_t start,
> static void kvm_gmem_invalidate_begin(struct inode *inode, pgoff_t start,
> pgoff_t end)
> {
> - struct list_head *gmem_list = &inode->i_mapping->i_private_list;
> enum kvm_gfn_range_filter attr_filter;
> struct gmem_file *f;
>
> attr_filter = kvm_gmem_get_invalidate_filter(inode);
>
> - list_for_each_entry(f, gmem_list, entry)
> + kvm_gmem_for_each_file(f, inode->i_mapping)
> __kvm_gmem_invalidate_begin(f, start, end, attr_filter);
> }
>
> @@ -184,10 +186,9 @@ static void __kvm_gmem_invalidate_end(struct gmem_file *f, pgoff_t start,
> static void kvm_gmem_invalidate_end(struct inode *inode, pgoff_t start,
> pgoff_t end)
> {
> - struct list_head *gmem_list = &inode->i_mapping->i_private_list;
> struct gmem_file *f;
>
> - list_for_each_entry(f, gmem_list, entry)
> + kvm_gmem_for_each_file(f, inode->i_mapping)
> __kvm_gmem_invalidate_end(f, start, end);
> }
>
Reviewed-by: Shivank Garg <shivankg@....com>
Thanks,
Shivank
Powered by blists - more mailing lists