linux-kernel - Re: [PATCH v1] Revert "tracing: Fix tracing_marker may trigger page fault during preempt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251007202113.1ce212a9@gandalf.local.home>
Date: Tue, 7 Oct 2025 20:21:13 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Runping Lai <runpinglai@...gle.com>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Wattson CI <wattson-external@...gle.com>,
 kernel-team@...roid.com, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, Luo Gengkun
 <luogengkun@...weicloud.com>, Linus Torvalds
 <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v1] Revert "tracing: Fix tracing_marker may trigger page
 fault during preempt_disable"

On Tue, 7 Oct 2025 16:25:41 -0700
Runping Lai <runpinglai@...gle.com> wrote:

> On Tue, Oct 7, 2025 at 2:40 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > On Tue, 7 Oct 2025 16:31:41 -0400
> > Steven Rostedt <rostedt@...dmis.org> wrote:
> >  
> > > +static void trace_user_fault_buffer_free(struct trace_user_buf_info *tinfo)
> > > +{
> > > +     char *buf;
> > > +     int cpu;
> > > +
> > > +     for_each_possible_cpu(cpu) {
> > > +             buf = per_cpu_ptr(tinfo->tbuf, cpu)->buf;
> > > +             kfree(buf);
> > > +     }  
> >
> > Oops, missed:
> >
> >         free_percpu(tinfo->tbuf);
> >
> > here.  
> 
> Hey Steve,
> 
> Thanks for providing the buffer-based solution. I tried it and it
> fixes the problem!
> However, the first experiment, adding pagefault_disable/enable()
> around copy_nofault()
> doesn't help. Still having the same problem. I suppose the issue is
> more than pagefault?
> 
> Can you please suggest the next move? I can also do more tests if needed.
> 

I may need to make this patch the official solution.

-- Steve