[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP4=nvTjauRawBPTnGEztZpdDSNhGpgSJtjoTFuq+cCQHP5oEg@mail.gmail.com>
Date: Wed, 8 Oct 2025 10:51:37 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Gopi Krishna Menon <krishnagopi487@...il.com>
Cc: rostedt@...dmis.org, corbet@....net, linux-trace-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
skhan@...uxfoundation.org, david.hunter.linux@...il.com, khalid@...nel.org,
linux-kernel-mentees@...ts.linux.dev, crwood@...hat.com,
costa.shul@...hat.com, jkacur@...hat.com,
Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [PATCH 1/8] Documentation/rtla: rename common_appendix.rst
Ășt 7. 10. 2025 v 20:55 odesĂlatel Gopi Krishna Menon
<krishnagopi487@...il.com> napsal:
>
> common_appendix.rst is intended to be included by other rtla documents
> and is not meant to be built as a standalone document.
>
> Rename common_appendix.rst to common_appendix.txt to maintain
> consistency with other common_*.txt files and prevent Sphinx from
> building it as a standalone document. Update all include references
> accordingly.
>
> Suggested-by: Bagas Sanjaya <bagasdotme@...il.com>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@...il.com>
> ---
Thanks for the patches! I completely missed that the refactoring of
the docs broke Sphinx, I only tested RTLA's man page generation when
doing the review...
Could you squash the changes into one patch? See the kernel documentation [1]:
"... On the other hand, if you make a single change to numerous files,
group those changes into a single patch. Thus a single logical change
is contained within a single patch."
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes
Thanks,
Tomas
Powered by blists - more mailing lists