linux-kernel - Re: [PATCH v1] tools/rtla: Add missing --quiet option to timerlat hist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvTDsoejezFNcS1uWftF5CkuKNb-QbBDYzZjrnHHj5RVzg@mail.gmail.com>
Date: Wed, 8 Oct 2025 10:55:45 +0200
From: Tomas Glozar <tglozar@...hat.com>
To: Costa Shulyupin <costa.shul@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Crystal Wood <crwood@...hat.com>, 
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Add missing --quiet option to timerlat hist

st 8. 10. 2025 v 10:46 odesílatel Costa Shulyupin
<costa.shul@...hat.com> napsal:
>
> Actually, osnoise hist also lacks the --quiet option, and this appears
> to be intentional.
>

Yeah, --quiet is used to suppress printing every second, hist has no
such functionality, so it doesn't do anything there. See:

[tglozar@cs9 rtla]$ grep -r 'params->common.quiet' src/*.c
src/osnoise_top.c:      if (!params->common.quiet)
src/osnoise_top.c:                      params->common.quiet = 1;
src/osnoise_top.c:      if (isatty(STDOUT_FILENO) && !params->common.quiet)
src/timerlat_top.c:     if (!params->common.quiet)
src/timerlat_top.c:                     params->common.quiet = 1;
src/timerlat_top.c:     if (isatty(STDOUT_FILENO) && !params->common.quiet)
src/timerlat_top.c:             wait_retval =
timerlat_bpf_wait(params->common.quiet ? -1 :
src/timerlat_top.c:             if (!params->common.quiet)

Tomas