[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6e5f63d1-8e07-45dd-8e98-6d843246ac59@oss.qualcomm.com>
Date: Wed, 8 Oct 2025 11:24:59 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Jingzhou Zhu <newwheatzjz@...omail.com>, andersson@...nel.org,
konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH v5 2/2] arm64: dts: qcom: Add support for Huawei MateBook
E 2019
On 10/8/25 3:54 AM, Jingzhou Zhu wrote:
> Add device tree for Huawei MateBook E 2019, which is a 2-in-1 tablet based
> on Qualcomm's sdm850 platform.
>
> Supported features:
> - ADSP, CDSP and SLPI
> - Volume Key
> - Power Key
> - Tablet Mode Switching
> - Display
> - Touchscreen
> - Stylus
> - WiFi [1]
> - Bluetooth [2]
> - GPU
> - USB
> - Keyboard
> - Touchpad
> - UFS
> - SD Card
> - Audio (right internal mic and headphone mic not working)
> - Mobile Network
Just some cosmetic notes
[...]
> +&pm8998_gpios {
> + sw_edp_1p2_en: sw-edp-1p2-en-state {
> + pins = "gpio9";
> + function = "normal";
> +
> + bias-disable;
odd \n-s inbetween
[...]
> + mm1-dai-link {
> + link-name = "MultiMedia1";
> + cpu {
a \n between the last property and the subsequent subnode is customary
[...]
> + slim-dai-link {
> + link-name = "SLIM Playback";
> + cpu {
> + sound-dai = <&q6afedai SLIMBUS_0_RX>;
> + };
> +
> + platform {
> + sound-dai = <&q6routing>;
> + };
> +
> + codec {
> + sound-dai = <&left_spkr>, <&right_spkr>, <&swm 0>, <&wcd9340 AIF1_PB>;
> + };
'co'dec < 'cp'u < 'p'latform
[...]
> +&tlmm {
> + gpio-reserved-ranges = <0 4>, <81 4>;
Would you happen to know what these correspond to? See e.g. x1-crd.dtsi
> +
> + cam_indicator_en: cam-indicator-en-state {
> + pins = "gpio12";
> + function = "gpio";
> +
> + drive-strength = <2>;
strange separatory \n-s here too
lgtm otherwise
Konrad
Powered by blists - more mailing lists