linux-kernel - Re: [PATCH v2 02/13] ext4: correct the checking of quota files before moving extents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <le2eumghjeqpmng4wubvwgp5tqevhc35q3qxxkczuvthrregbw@errdd2w7d3hs>
Date: Wed, 8 Oct 2025 13:17:11 +0200
From: Jan Kara <jack@...e.cz>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, 
	yi.zhang@...wei.com, libaokun1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 02/13] ext4: correct the checking of quota files
 before moving extents

On Thu 25-09-25 17:25:58, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@...wei.com>
> 
> The move extent operation should return -EOPNOTSUPP if any of the inodes
> is a quota inode, rather than requiring both to be quota inodes.
> 
> Fixes: 02749a4c2082 ("ext4: add ext4_is_quota_file()")
> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>

Funny bug. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/move_extent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
> index 4b091c21908f..0f4b7c89edd3 100644
> --- a/fs/ext4/move_extent.c
> +++ b/fs/ext4/move_extent.c
> @@ -485,7 +485,7 @@ mext_check_arguments(struct inode *orig_inode,
>  		return -ETXTBSY;
>  	}
>  
> -	if (ext4_is_quota_file(orig_inode) && ext4_is_quota_file(donor_inode)) {
> +	if (ext4_is_quota_file(orig_inode) || ext4_is_quota_file(donor_inode)) {
>  		ext4_debug("ext4 move extent: The argument files should not be quota files [ino:orig %lu, donor %lu]\n",
>  			orig_inode->i_ino, donor_inode->i_ino);
>  		return -EOPNOTSUPP;
> -- 
> 2.46.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR