linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: msm8939-asus-z00t: add initial device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7abe83dc-5469-48e1-8964-ce3377d82a4d@oss.qualcomm.com>
Date: Wed, 8 Oct 2025 13:38:45 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Erikas Bitovtas <xerikasxx@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 2/2] arm64: dts: qcom: msm8939-asus-z00t: add initial
 device tree

On 9/30/25 3:20 PM, Erikas Bitovtas wrote:
> Add an initial device tree for Asus ZenFone 2 Laser/Selfie. This
> includes support for:
> - UART
> - USB
> - Internal storage
> - MicroSD
> - Volume keys
> - Touchscreen: Focaltech FT5306
> - Accelerometer: Invensense MPU6515
> - Magnetometer: Asahi Kasei AK09911
> - Vibrator
> - Audio input and output
> - Modem
> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@...il.com>
> ---

[...]

> +&blsp_uart2 {
> +	pinctrl-0 = <&blsp_uart2_console_default>;
> +	pinctrl-1 = <&blsp_uart2_console_sleep>;
> +	pinctrl-names = "default", "sleep";
> +	status = "okay";

nit: a newline before 'status' is customary

[...]

> +&tlmm {
> +	gpio_keys_default: gpio-keys-default-state {
> +		pins = "gpio107", "gpio117";

pin configuration nodes are best sorted by their pin number, please
reshuffle them

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-pull-up;
> +	};
> +
> +	imu_default: imu-default-state {
> +		pins = "gpio36";
> +		function = "gpio";
> +
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +
> +	mag_reset_default: mag-reset-default-state {
> +		pins = "gpio112";
> +		function = "gpio";
> +
> +		drive-strength = <2>;
> +		bias-disable;

odd \n-s in some entries, please remove them

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad