linux-kernel - Re: [PATCH v2 09/13] ext4: rename mext_page_mkuptodate() to mext_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gxjjbokvnurzrwc64oqlisadx5anmwdv67qit7ttd3wlunj6d5@ab35hupg4zby>
Date: Wed, 8 Oct 2025 13:51:26 +0200
From: Jan Kara <jack@...e.cz>
To: Zhang Yi <yi.zhang@...weicloud.com>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, 
	yi.zhang@...wei.com, libaokun1@...wei.com, yukuai3@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 09/13] ext4: rename mext_page_mkuptodate() to
 mext_folio_mkuptodate()

On Thu 25-09-25 17:26:05, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@...wei.com>
> 
> mext_page_mkuptodate() no longer works on a single page, so rename it to
> mext_folio_mkuptodate().
> 
> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/move_extent.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
> index 0191a3c746db..2df6072b26c0 100644
> --- a/fs/ext4/move_extent.c
> +++ b/fs/ext4/move_extent.c
> @@ -165,7 +165,7 @@ mext_folio_double_lock(struct inode *inode1, struct inode *inode2,
>  }
>  
>  /* Force folio buffers uptodate w/o dropping folio's lock */
> -static int mext_page_mkuptodate(struct folio *folio, size_t from, size_t to)
> +static int mext_folio_mkuptodate(struct folio *folio, size_t from, size_t to)
>  {
>  	struct inode *inode = folio->mapping->host;
>  	sector_t block;
> @@ -358,7 +358,7 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode,
>  data_copy:
>  	from = offset_in_folio(folio[0],
>  			       orig_blk_offset << orig_inode->i_blkbits);
> -	*err = mext_page_mkuptodate(folio[0], from, from + replaced_size);
> +	*err = mext_folio_mkuptodate(folio[0], from, from + replaced_size);
>  	if (*err)
>  		goto unlock_folios;
>  
> -- 
> 2.46.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR