linux-kernel - Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ac39a3e-d1a2-40d8-a3d1-b422acc720cc@kernel.org>
Date: Wed, 8 Oct 2025 10:55:40 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sven Püschel <s.pueschel@...gutronix.de>,
 Jacob Chen <jacob-chen@...wrt.com>,
 Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Heiko Stuebner
 <heiko@...ech.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH 16/16] media: rockchip: rga: add rga3 support

On 08/10/2025 01:05, Sven Püschel wrote:
> Hi Krzysztof,
> 
> On 10/7/25 10:39 AM, Krzysztof Kozlowski wrote:
>> On 07/10/2025 17:32, Sven Püschel wrote:
>>> Add support for the RGA3 unit contained in the RK3588.
>>>
>>> Only a basic feature set consisting of scaling and color conversion is
>>> implemented. Advanced features like rotation and cropping will just be
>>> ignored. Also the BT601F color space conversion is currently hard coded.
>>>
>>> The register address defines were copied from the
>>> vendor Rockchip kernel sources and slightly adjusted to not start at 0
>>> again for the cmd registers.
>>>
>>> Signed-off-by: Sven Püschel <s.pueschel@...gutronix.de>
>>> ---
>>>   drivers/media/platform/rockchip/rga/Makefile  |   2 +-
>>>   drivers/media/platform/rockchip/rga/rga.c     |   4 +
>>>   drivers/media/platform/rockchip/rga/rga.h     |   2 +-
>>>   drivers/media/platform/rockchip/rga/rga3-hw.c | 490 ++++++++++++++++++++++++++
>>>   drivers/media/platform/rockchip/rga/rga3-hw.h | 186 ++++++++++
>>>   5 files changed, 682 insertions(+), 2 deletions(-)
>> Your order of patches is a mess. DTS cannot be in the middle. In fact,
>> DTS should not be even in this patchset, because you are targeting media.
> 
> sorry to bother you, but could you go into a bit more detail on how it 
> should be done correctly?

DTS cannot be before drivers, because this suggests that drivers depends
on DTS, which would be a NAK. See also maintainer soc profile. To avoid
having such impression of fake dependency, DTS must be placed at the end
of patchset (except the obvious part: nothing in your code can depend on
it).

Best regards,
Krzysztof