linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Update regulator settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yjqg2xani47xzik4hrxcuaa4wwft4hyvf4dcjf5mosgdrrfxbc@fum65ap3zha4>
Date: Wed, 8 Oct 2025 15:59:01 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Rakesh Kota <rakesh.kota@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>,
        tingguo.cheng@....qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Update regulator
 settings

On Wed, Oct 08, 2025 at 02:44:58PM +0200, Konrad Dybcio wrote:
> On 9/19/25 12:39 PM, Rakesh Kota wrote:
> > Update min/max voltage settings for regulators below to align
> > with the HW specification
> > vreg_l3b_0p504
> > vreg_l6b_1p2
> > vreg_l11b_1p504
> > vreg_l14b_1p08
> > vreg_l16b_1p1
> > vreg_l17b_1p7
> > vreg_s1c_2p19
> > vreg_l8c_1p62
> > vreg_l9c_2p96
> > vreg_l12c_1p65.
> 
> You should rename the regulators that have now changed their
> ranges.. I'm a big fan of stripping the voltage suffix entirely
> fwiw

I think it's typical to follow the net names from the schematics. Which
can include voltages. And which (unfortunately) can be incorrect and
misleading.

> 
> [...]
> 
> >  		vreg_l9c_2p96: ldo9 {
> >  			regulator-name = "vreg_l9c_2p96";
> >  			regulator-min-microvolt = <2700000>;
> > -			regulator-max-microvolt = <35440000>;
> > +			regulator-max-microvolt = <3544000>;
> 
> This change is funny, no one noticed that before..
> 
> Konrad

-- 
With best wishes
Dmitry