[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aOZhyhmIv_d_knXK@kuha.fi.intel.com>
Date: Wed, 8 Oct 2025 16:06:18 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Jameson Thies <jthies@...gle.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
dmitry.baryshkov@....qualcomm.com, bleung@...omium.org,
gregkh@...uxfoundation.org, akuchynski@...omium.org,
abhishekpandit@...omium.org, sebastian.reichel@...labora.com,
linux-pm@...r.kernel.org
Subject: Re: [PATCH 4/6] usb: typec: ucsi: Report power supply change on sink
path change
On Tue, Oct 07, 2025 at 12:00:05AM +0000, Jameson Thies wrote:
> Update the UCSI interface driver to report a power supply change when
> the PPM sets the Sink Path Change bit.
>
> Signed-off-by: Jameson Thies <jthies@...gle.com>
> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 7b718049d0d1..1a7d850b11ea 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1293,7 +1293,7 @@ static void ucsi_handle_connector_change(struct work_struct *work)
> if (change & UCSI_CONSTAT_CAM_CHANGE)
> ucsi_partner_task(con, ucsi_check_altmodes, 1, HZ);
>
> - if (change & UCSI_CONSTAT_BC_CHANGE)
> + if (change & UCSI_CONSTAT_BC_CHANGE || change & UCSI_CONSTAT_SINK_PATH_CHANGE)
How about:
if (change & (UCSI_CONSTAT_BC_CHANGE | UCSI_CONSTAT_SINK_PATH_CHANGE))
> ucsi_port_psy_changed(con);
>
> if (con->ucsi->version >= UCSI_VERSION_2_1 &&
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index cce93af7461b..35993bc34d4d 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -382,6 +382,7 @@ struct ucsi_cable_property {
> #define UCSI_CONSTAT_BC_CHANGE BIT(9)
> #define UCSI_CONSTAT_PARTNER_CHANGE BIT(11)
> #define UCSI_CONSTAT_POWER_DIR_CHANGE BIT(12)
> +#define UCSI_CONSTAT_SINK_PATH_CHANGE BIT(13)
> #define UCSI_CONSTAT_CONNECT_CHANGE BIT(14)
> #define UCSI_CONSTAT_ERROR BIT(15)
>
> --
> 2.51.0.618.g983fd99d29-goog
--
heikki
Powered by blists - more mailing lists