linux-kernel - Re: [PATCH v4 2/4] dt-bindings: mfd: qcom,spmi-pmic: add qcom,pm4125-codec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDCKWVH8ORLM.357D9IKQK9YN8@linaro.org>
Date: Wed, 08 Oct 2025 03:18:47 +0100
From: "Alexey Klimov" <alexey.klimov@...aro.org>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: "Srinivas Kandagatla" <srini@...nel.org>, "Liam Girdwood"
 <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Stephen Boyd" <sboyd@...nel.org>, "Lee
 Jones" <lee@...nel.org>, "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai"
 <tiwai@...e.com>, <linux-arm-msm@...r.kernel.org>,
 <linux-sound@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Dmitry Baryshkov"
 <dmitry.baryshkov@....qualcomm.com>, "Srinivas Kandagatla"
 <srinivas.kandagatla@....qualcomm.com>, <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v4 2/4] dt-bindings: mfd: qcom,spmi-pmic: add
 qcom,pm4125-codec compatible

On Thu Sep 18, 2025 at 3:03 AM BST, Krzysztof Kozlowski wrote:
> On Mon, Sep 15, 2025 at 05:27:49PM +0100, Alexey Klimov wrote:
>> Add qcom,pm4125-codec compatible to pattern properties in mfd
>> qcom,spmi-pmic schema so the devicetree for this audio block of PMIC
>> can be validated properly.
>> 
>> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> index 078a6886f8b1e9ceb2187e988ce7c9514ff6dc2c..776c51a66f6e7260b7e3e183d693e3508cbc531e 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -137,6 +137,12 @@ patternProperties:
>>  
>>    "^audio-codec@[0-9a-f]+$":
>>      type: object
>> +    oneOf:
>> +      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
>> +      - properties:
>> +          compatible:
>> +            const: qcom,pm4125-codec
>
>
> Not much improved. Same feedback applies.

Around the time of sending this I thought to set separate follow-up patch
that fixes the other part here -- pm8916-wcd-analog-codec.

At this point, is it fine to send follow-up patch that does smth like
this:

+    oneOf:
+      - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml#
+      - properties:
+          compatible:
+              - enaum:
+                - qcom,pm4125-codec
+                - qcom,pm8916-wcd-analog-codec

?

(I didn't check how if it will compile or pass checks)

Hope this is okay.

Best regards,
Alexey