linux-kernel - Re: [PATCH v1] platform/x86/amd: pmc: Add Lenovo Legion Go 2 to pmc quirk list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwGkbJ7qQw6EXF96UjzF5GOi4qRxp2JZFsi4MPbNa97Cyg@mail.gmail.com>
Date: Wed, 8 Oct 2025 16:18:31 +0200
From: Antheas Kapenekakis <lkml@...heas.dev>
To: Mario Limonciello <superm1@...nel.org>
Cc: Shyam-sundar.S-k@....com, hansg@...nel.org, ilpo.jarvinen@...ux.intel.com,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mark Pearson <mpearson-lenovo@...ebb.ca>
Subject: Re: [PATCH v1] platform/x86/amd: pmc: Add Lenovo Legion Go 2 to pmc
 quirk list

On Wed, 8 Oct 2025 at 16:06, Mario Limonciello <superm1@...nel.org> wrote:
>
> On 10/8/25 8:50 AM, Antheas Kapenekakis wrote:
> > The Lenovo Legion Go 2 takes a long time to resume from suspend.
> > This is due to it having an nvme resume handler that interferes
> > with IOMMU mappings. It is a common issue with older Lenovo
> > laptops. Adding it to that quirk list fixes this issue.
> >
> > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4618
> > Suggested-by: Mario Limonciello <mario.limonciello@....com>
> > Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
>
> This makes sense for BIOS in the field.
> If this is fixed in the BIOS later I'd like to narrow the quirk at a
> later time.

That would be ideal. Especially since the issue is known and fixed in
Lenovo laptops from the last three years so it should be easy to fix.
Currently, there are two BIOS versions that would need quirking,
RRCN11WW, RRCN10WW.

What are the side effects from blocking the Nvme handler? Other than
OPAL support handled by the built in BIOS, which is a semi-antifeature
for a device like this.

I should note that there are other pressing issues with the device.
Users report HDR brightness is not at correct levels compared to
Windows and the brightness slider sometimes breaks after sleep.

HDR brightness might be a bug in Bazzite specifically, due to a
blanket quirk we apply to disable the PQ curve on internal displays
(essentially the panel that had the brightness bug on e.g. Zotac Zone
also reports supporting PQ but it does not). I disabled it for the Go
2 but have not double checked it is disabled due to not having a
device. Users said there was an improvement after disabling it though.

Antheas

> Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>
>
> > ---
> >   drivers/platform/x86/amd/pmc/pmc-quirks.c | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >
> > diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> > index d63aaad7ef59..0fadcf5f288a 100644
> > --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> > +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> > @@ -204,6 +204,23 @@ static const struct dmi_system_id fwbug_list[] = {
> >                       DMI_MATCH(DMI_PRODUCT_NAME, "82ND"),
> >               }
> >       },
> > +     /* https://gitlab.freedesktop.org/drm/amd/-/issues/4618 */
> > +     {
> > +             .ident = "Lenovo Legion Go 2",
> > +             .driver_data = &quirk_s2idle_bug,
> > +             .matches = {
> > +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "83N0"),
> > +             }
> > +     },
> > +     {
> > +             .ident = "Lenovo Legion Go 2",
> > +             .driver_data = &quirk_s2idle_bug,
> > +             .matches = {
> > +                     DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "83N1"),
> > +             }
> > +     },
> >       /* https://gitlab.freedesktop.org/drm/amd/-/issues/2684 */
> >       {
> >               .ident = "HP Laptop 15s-eq2xxx",
> >
> > base-commit: a8cdf51cda30f7461a98af821e8a28c5cb5f8878
>
>