linux-kernel - Re: [PATCH] x86/resctrl: Fix buggy overflow when reactivating previously Unavailable RMID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aOaCDee7xbhA0ji3@e133380.arm.com>
Date: Wed, 8 Oct 2025 16:23:57 +0100
From: Dave Martin <Dave.Martin@....com>
To: Reinette Chatre <reinette.chatre@...el.com>
Cc: Babu Moger <babu.moger@....com>, tony.luck@...el.com,
	james.morse@....com, tglx@...utronix.de, mingo@...hat.com,
	bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
	hpa@...or.com, linux-kernel@...r.kernel.org, peternewman@...gle.com,
	eranian@...gle.com, gautham.shenoy@....com
Subject: Re: [PATCH] x86/resctrl: Fix buggy overflow when reactivating
 previously Unavailable RMID

Hi,

On Tue, Oct 07, 2025 at 01:23:36PM -0700, Reinette Chatre wrote:
> Hi Babu,
> 
> Thank you for catching and preparing a fix for this issue.
> 
> On 10/6/25 4:13 PM, Babu Moger wrote:
> > The issue was observed during testing on systems with multiple resctrl
> > domains, where tasks were dynamically moved between domains.
> 
> (please let changelog stand on its own and not be a continuation of subject line)

[...]

[Quick, drive-by observation:]

Can I add that the commit message also seems way too long?

I think some of the description of the problem symptom could probably
be after the tearoff -- there doesn't seem to be a clear statement of
what is actually wrong in the code, or of why the change made in the
patch fixes it (or if there is, I struggled to find it.)

I puzzled over this for some minutes before I figured out this patch is
fixing something that is not upstream, yet.  A statement to that effect
would have helped.

Possibly I didn't read carefully enough...

Cheers
---Dave