linux-kernel - Re: [PATCH] accel/amdxdna: Resume power for creating and destroying hardware context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4a9ad2a-9258-7b4b-9e46-19378e1fd76a@amd.com>
Date: Wed, 8 Oct 2025 08:39:46 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: Mario Limonciello <superm1@...nel.org>, <ogabbay@...nel.org>,
	<quic_jhugo@...cinc.com>, <maciej.falkowski@...ux.intel.com>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <max.zhen@....com>, <sonal.santan@....com>
Subject: Re: [PATCH] accel/amdxdna: Resume power for creating and destroying
 hardware context

Applied to drm-misc-next

On 10/8/25 08:03, Mario Limonciello wrote:
> On 10/7/25 11:53 PM, Lizhi Hou wrote:
>> When the hardware is powered down by auto-suspend, creating or 
>> destroying
>> a hardware context without resuming power will fail.
>> Call amdxdna_pm_resume_get() before requesting the hardware to create or
>> destroy a hardware context.
>>
>> Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
>> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
>
> Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>
>
>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index 691fdb3b008f..ab4d66f1325d 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -610,10 +610,14 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>           goto free_entity;
>>       }
>>   +    ret = amdxdna_pm_resume_get(xdna);
>> +    if (ret)
>> +        goto free_col_list;
>> +
>>       ret = aie2_alloc_resource(hwctx);
>>       if (ret) {
>>           XDNA_ERR(xdna, "Alloc hw resource failed, ret %d", ret);
>> -        goto free_col_list;
>> +        goto suspend_put;
>>       }
>>         ret = aie2_map_host_buf(xdna->dev_handle, hwctx->fw_ctx_id,
>> @@ -628,6 +632,7 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>           XDNA_ERR(xdna, "Create syncobj failed, ret %d", ret);
>>           goto release_resource;
>>       }
>> +    amdxdna_pm_suspend_put(xdna);
>>         hwctx->status = HWCTX_STAT_INIT;
>>       ndev = xdna->dev_handle;
>> @@ -640,6 +645,8 @@ int aie2_hwctx_init(struct amdxdna_hwctx *hwctx)
>>     release_resource:
>>       aie2_release_resource(hwctx);
>> +suspend_put:
>> +    amdxdna_pm_suspend_put(xdna);
>>   free_col_list:
>>       kfree(hwctx->col_list);
>>   free_entity:
>