[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DDD2MGRNMEWB.1ZSVQ2HW7V4BY@kernel.org>
Date: Wed, 08 Oct 2025 18:11:31 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Alistair Popple" <apopple@...dia.com>
Cc: <rust-for-linux@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
<acourbot@...dia.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
<alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
"Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
"Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
<maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
"Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
<jhubbard@...dia.com>, "Joel Fernandes" <joelagnelf@...dia.com>, "Timur
Tabi" <ttabi@...dia.com>, <linux-kernel@...r.kernel.org>,
<nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH v4 03/13] gpu: nova-core: gsp: Create wpr metadata
On Wed Oct 8, 2025 at 2:12 AM CEST, Alistair Popple wrote:
> --- a/drivers/gpu/nova-core/firmware/gsp.rs
> +++ b/drivers/gpu/nova-core/firmware/gsp.rs
> @@ -131,7 +131,7 @@ pub(crate) struct GspFirmware {
> /// Size in bytes of the firmware contained in [`Self::fw`].
> pub size: usize,
> /// Device-mapped GSP signatures matching the GPU's [`Chipset`].
> - signatures: DmaObject,
> + pub signatures: DmaObject,
> /// GSP bootloader, verifies the GSP firmware before loading and running it.
> pub bootloader: RiscvFirmware,
> }
> @@ -216,7 +216,6 @@ pub(crate) fn new<'a, 'b>(
> }))
> }
>
> - #[expect(unused)]
> /// Returns the DMA handle of the radix3 level 0 page table.
> pub(crate) fn radix3_dma_handle(&self) -> DmaAddress {
> self.level0.dma_handle()
> diff --git a/drivers/gpu/nova-core/firmware/riscv.rs b/drivers/gpu/nova-core/firmware/riscv.rs
> index 04f1283abb72..76d0d36fee3e 100644
> --- a/drivers/gpu/nova-core/firmware/riscv.rs
> +++ b/drivers/gpu/nova-core/firmware/riscv.rs
> @@ -55,11 +55,11 @@ fn new(bin_fw: &BinFirmware<'_>) -> Result<Self> {
> #[expect(unused)]
> pub(crate) struct RiscvFirmware {
> /// Offset at which the code starts in the firmware image.
> - code_offset: u32,
> + pub code_offset: u32,
> /// Offset at which the data starts in the firmware image.
> - data_offset: u32,
> + pub data_offset: u32,
> /// Offset at which the manifest starts in the firmware image.
> - manifest_offset: u32,
> + pub manifest_offset: u32,
> /// Application version.
> app_version: u32,
> /// Device-mapped firmware image.
As mentioned in a previous patch, the member visibility should at most match the
stuct visibility.
Otherwise, LGTM!
Powered by blists - more mailing lists