linux-kernel - Re: [PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the freshly introduced driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17b5977b-d0e6-4027-98f9-171b9e18b1bc@ixit.cz>
Date: Wed, 8 Oct 2025 18:09:19 +0200
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] arm64: dts: qcom: sdm845-oneplus-fajita: Use the
 freshly introduced driver

On 08/10/2025 17:54, Dmitry Baryshkov wrote:
> On Wed, Oct 08, 2025 at 04:05:30PM +0200, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> Switch from older effort to support different panels within one driver
>> (which already dropped support for the HW) to the freshly written one.
> 
> Please disconnect the driver and the DT description. DT can be used by
> other instances (U-Boot, OpenBSD, etc.).

Just to note, there are no users (anywhere) for this compatible.

Would be the change of the commit wording enough in this case?

If not, I would then propose to use for OnePlus 6T just an extension as

compatible = "samsung,s6e3fc2x01-ams641rw", "samsung,s6e3fc2x01";

Thank you

> 
>>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> index 7e75decfda052..55b3e94dd9726 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts
>> @@ -32,7 +32,7 @@ battery: battery {
>>   &display_panel {
>>   	status = "okay";
>>   
>> -	compatible = "samsung,s6e3fc2x01";
>> +	compatible = "samsung,s6e3fc2x01-ams641rw";
>>   };
>>   
>>   &i2c4 {
>>
>> -- 
>> 2.51.0
>>
>>
> 

-- 
David Heidelberg