linux-kernel - Re: [PATCH] can: treewide: remove can_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251008-hallowed-zebu-of-wonder-638a63-mkl@pengutronix.de>
Date: Wed, 8 Oct 2025 20:04:55 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: Oliver Hartkopp <socketcan@...tkopp.net>, 
	Nicolas Ferre <nicolas.ferre@...rochip.com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, 
	Claudiu Beznea <claudiu.beznea@...on.dev>, Dario Binacchi <dario.binacchi@...rulasolutions.com>, 
	Max Staudt <max@...as.org>, Pavel Pisa <pisa@....felk.cvut.cz>, 
	Ondrej Ille <ondrej.ille@...il.com>, Stefan Mätje <stefan.maetje@....eu>, 
	socketcan@....eu, Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, kernel@...gutronix.de, 
	Heiko Stuebner <heiko@...ech.de>, Manivannan Sadhasivam <mani@...nel.org>, 
	Thomas Kopp <thomas.kopp@...rochip.com>, Chen-Yu Tsai <wens@...e.org>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Frank Jungclaus <frank.jungclaus@....eu>, "Ji-Ze Hong (Peter Hong)" <peter_hong@...tek.com.tw>, 
	Yasushi SHOJI <yashi@...cecubics.com>, Ming Yu <tmyu0@...oton.com>, 
	Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>, Michal Simek <michal.simek@....com>, linux-can@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] can: treewide: remove can_change_mtu()

On 03.10.2025 12:16:38, Vincent Mailhol wrote:
> can_change_mtu() became obsolete by commit 23049938605b ("can:
> populate the minimum and maximum MTU values"). Now that
> net_device->min_mtu and net_device->max_mtu are populated, all the
> checks are already done by dev_validate_mtu() in net/core/dev.c.
> 
> Remove the net_device_ops->ndo_change_mtu() callback of all the
> physical interfaces, then remove can_change_mtu(). Only keep the
> vcan_change_mtu() and vxcan_change_mtu() because the virtual
> interfaces use their own different MTU logic.
> 
> The only functional change this patch introduces is that now the user
> will be able to change the MTU even if the interface is up. This does
> not matter for Classical CAN and CAN FD because their MTU range is
> composed of only one value, respectively CAN_MTU and CANFD_MTU. For
> the upcoming CAN XL, the MTU will be configurable within the
> CANXL_MIN_MTU to CANXL_MAX_MTU range at any time, even if the
> interface is up. This is consistent with the other net protocols and
> does not contradict ISO 11898-1:2024 as having a modifiable MTU is a
> kernel extension.
> 
> Signed-off-by: Vincent Mailhol <mailhol@...nel.org>

Applied to linux-can-next.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)