linux-kernel - [PATCH 1/2] smb: client: Return directly after a failed SMB2_ioctl() in smb3_simple_fallocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a91cb2c-4353-496e-8f16-2e700df692bd@web.de>
Date: Wed, 8 Oct 2025 20:46:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
 Aurelien Aptel <aaptel@...e.com>, Bharath SM <bharathsm@...rosoft.com>,
 Paulo Alcantara <pc@...guebit.org>,
 Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N <sprasad@...rosoft.com>, Steve French <sfrench@...ba.org>,
 Tom Talpey <tom@...pey.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [PATCH 1/2] smb: client: Return directly after a failed SMB2_ioctl()
 in smb3_simple_fallocate_range()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 8 Oct 2025 20:02:00 +0200

* Return directly after a call of the function “SMB2_ioctl” failed
  at the beginning.

* Delete an initialisation for the local variable “out_data”
  which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/smb/client/smb2ops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 7c3e96260fd4..ec188dedbf97 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -3537,7 +3537,7 @@ static int smb3_simple_fallocate_range(unsigned int xid,
 				       struct cifsFileInfo *cfile,
 				       loff_t off, loff_t len)
 {
-	struct file_allocated_range_buffer in_data, *out_data = NULL, *tmp_data;
+	struct file_allocated_range_buffer in_data, *out_data, *tmp_data;
 	u32 out_data_len;
 	char *buf = NULL;
 	loff_t l;
@@ -3552,7 +3552,7 @@ static int smb3_simple_fallocate_range(unsigned int xid,
 			1024 * sizeof(struct file_allocated_range_buffer),
 			(char **)&out_data, &out_data_len);
 	if (rc)
-		goto out;
+		return rc;
 
 	buf = kzalloc(1024 * 1024, GFP_KERNEL);
 	if (buf == NULL) {
-- 
2.51.0