linux-kernel - Re: [PATCH] NFS4: Apply delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ECC2D7B9-3D90-408F-AC4E-2E663E1FED3C@redhat.com>
Date: Wed, 08 Oct 2025 15:02:32 -0400
From: Benjamin Coddington <bcodding@...hat.com>
To: Joshua Watt <jpewhacker@...il.com>
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>
Subject: Re: [PATCH] NFS4: Apply delay_retrans to async operations

On 7 Oct 2025, at 17:22, Joshua Watt wrote:

> From: Joshua Watt <jpewhacker@...il.com>
>
> The setting of delay_retrans is applied to synchronous RPC operations
> because the retransmit count is stored in same struct nfs4_exception
> that is passed each time an error is checked. However, for asynchronous
> operations (READ, WRITE, LOCKU, CLOSE, DELEGRETURN), a new struct
> nfs4_exception is made on the stack each time the task callback is
> invoked. This means that the retransmit count is always zero and thus
> delay_retrans never takes effect.
>
> Apply delay_retrans to these operations by tracking and updating their
> retransmit count.

Looks correct.  I wish we didn't have to assign these values back and forth,
but I don't see a better way to fix this.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben