| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20251008-m_can-cleanups-v1-7-1784a18eaa84@pengutronix.de> Date: Wed, 08 Oct 2025 21:07:42 +0200 From: Marc Kleine-Budde <mkl@...gutronix.de> To: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, Vincent Mailhol <mailhol@...nel.org>, Markus Schneider-Pargmann <msp@...libre.com> Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de, Marc Kleine-Budde <mkl@...gutronix.de> Subject: [PATCH 7/7] can: m_can: m_can_get_berr_counter(): don't wake up controller if interface is down If the interface is down, the CAN controller might be powered down, the clock disabled, and/or it's external reset asserted. Don't wake up the controller to read the CAN bus error counters, if the interface is down. Reviewed-by: Markus Schneider-Pargmann <msp@...libre.com> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de> --- drivers/net/can/m_can/m_can.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4451ea750b74..0b622248e229 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -790,6 +790,10 @@ static int m_can_get_berr_counter(const struct net_device *dev, struct m_can_classdev *cdev = netdev_priv(dev); int err; + /* Avoid waking up the controller if the interface is down */ + if (!(dev->flags & IFF_UP)) + return 0; + err = m_can_clk_start(cdev); if (err) return err; -- 2.51.0
Powered by blists - more mailing lists