linux-kernel - Re: [PATCH v2 1/7] dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9018af52-1c81-4d2d-8717-44e5372dbffa@ixit.cz>
Date: Thu, 9 Oct 2025 17:44:46 +0200
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Casey Connolly <casey.connolly@...aro.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 1/7] dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC
 with panel

On 09/10/2025 16:26, Dmitry Baryshkov wrote:
> On Thu, Oct 09, 2025 at 03:32:22PM +0200, David Heidelberg wrote:
>>
>>
>> On 09/10/2025 15:21, Dmitry Baryshkov wrote:
>>> On Thu, Oct 09, 2025 at 10:51:31AM +0200, Konrad Dybcio wrote:
>>>> On 10/8/25 8:57 PM, Dmitry Baryshkov wrote:
>>>>> On Wed, Oct 08, 2025 at 04:05:28PM +0200, David Heidelberg via B4 Relay wrote:
>>>>>> From: David Heidelberg <david@...t.cz>
>>>>>>
>>>>>> Basic description for S6E3FC2X01 DDIC with attached panel AMS641RW.
>>>>>>
>>>>>> Samsung AMS641RW is 6.41 inch, 1080x2340 pixels, 19.5:9 ratio panel
>>>>>>
>>>>>> Signed-off-by: David Heidelberg <david@...t.cz>
>>>>>> ---
>>>>>>    .../bindings/display/panel/samsung,s6e3fc2x01.yaml | 78 ++++++++++++++++++++++
>>>>>>    MAINTAINERS                                        |  5 ++
>>>>>>    2 files changed, 83 insertions(+)
>>>>>>
>>>>>
>>>>> Please also describe, why it's not enough to use defined compatible,
>>>>> samsung,s6e3fc2x01. Why do we need a separate schema and can't use the
>>>>> panel-simple-dsi.yaml
>>>>
>>>> panel-simple works for 'dumb' (perhaps a harsh word for 'made with
>>>> just the in-spec DCS commands in mind') panels, but Samsungs are
>>>> widely known to require a ton of vendor magic
>>>
>>> The question is about the _schema_. I think it's fine to have a driver
>>> for a panel covered by panel-simple-dsi.yaml.
>>
>> see display/panel/samsung,amoled-mipi-dsi.yaml
>> the OLED display don't fit well, but I wouldn't mind consolidating at some
>> point, but since we know very little (no datasheets), it's hard to do for
>> now. Maybe in the future when there will be more panels schemas, we can find
>> a way to consolidate into one big?
> 
> I'm looking for a simple answer ATM: it doesn't fit
> panel-simple-dsi.yaml because it needs foo bar baz, which is not a part
> of that schema.

v3 will have:

     dt-bindings: panel: Add Samsung S6E3FC2X01 DDIC with panel

     Basic description for S6E3FC2X01 DDIC with attached panel AMS641RW.

     Samsung AMS641RW is 6.41 inch, 1080x2340 pixels, 19.5:9 ratio panel

     panel-simple-dsi cannot be used because it's limited to one
     power-supply, while we use three.

> 
>>
>>>
>>>>
>>>> Perhaps the original change was made with an "oh it just works
>>>> surely there's no drawbacks possible" attitude, as the panel
>>>> was left initialized by the bootloader
> 

-- 
David Heidelberg