[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69ef6c4e-aea2-4528-9b5a-02488087ad0e@oss.qualcomm.com>
Date: Thu, 9 Oct 2025 17:48:09 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Alexey Klimov <alexey.klimov@...aro.org>,
Prasad Kumpatla <prasad.kumpatla@....qualcomm.com>,
Srinivas Kandagatla <srini@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Rao Mandadapu <quic_srivasam@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@....qualcomm.com, aiqun.yu@....qualcomm.com,
tingwei.zhang@....qualcomm.com, trilok.soni@....qualcomm.com,
yijie.yang@....qualcomm.com, jingyi.wang@....qualcomm.com
Subject: Re: [PATCH v2 1/5] ASoC: codecs: va-macro: Rework version checking
On 10/9/25 5:25 PM, Alexey Klimov wrote:
> On Thu Oct 9, 2025 at 3:36 PM BST, Prasad Kumpatla wrote:
>> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>
>> Open-code some of the registers to make the checks anywhere near human-
>> readable. Error out if the version is unsupported or if the VA macro
>> isn't supposed to be present within this LPASS instance (since we can
>> check for that now).
>
[...]
>> + if (version == LPASS_CODEC_VERSION_UNKNOWN) {
>> + dev_err(va->dev, "VA Macro v%u.%u.%u is not supported\n",
>> + maj, min, step);
>> + return -EOPNOTSUPP;
>> + }
>
> Why?
>
> As far as I understand the behaviour before this change is to continue
> even with unsupported LPASS va macro version. IIRC when I enabled sound
> on Kaanapali QRD device it worked even with unsupported version, it just
> needed a fix to calm down the warning.
>
> Why this needed to be changed to error out as unsupported now? Will there
> be a permanent damage to hw/fw if we continue?
Unsupported hw is unsupported, simple as that
We can not predict what a new hw version will bring and it's
better to have the human decide
Konrad
Powered by blists - more mailing lists