[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251009-squishy-poem-ddb0fdd9583d@spud>
Date: Thu, 9 Oct 2025 17:48:39 +0100
From: Conor Dooley <conor@...nel.org>
To: Jianping.Shen@...bosch.com
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, dima.fedrau@...il.com,
marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Christian.Lorenz3@...bosch.com, Ulrike.Frauendorf@...bosch.com,
Kai.Dolde@...bosch.com
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: imu: smi330: Add binding
On Thu, Oct 09, 2025 at 05:31:48PM +0200, Jianping.Shen@...bosch.com wrote:
> From: Jianping Shen <Jianping.Shen@...bosch.com>
>
> Add devicetree binding for Bosch imu smi330.
> The smi330 is a combined three axis angular rate and
> three axis acceleration sensor module.
>
> Signed-off-by: Jianping Shen <Jianping.Shen@...bosch.com>
https://lore.kernel.org/all/20250916-henna-rinsing-32a18a4d30b9@spud/
Why did you ignore my ack?
Didn't Jonathan already apply v4 of this two weeks ago, why is there
even a v5 to begin with?
Conor.
> ---
> .../bindings/iio/imu/bosch,smi330.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
> new file mode 100644
> index 00000000000..0270ca456d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi330.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/imu/bosch,smi330.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bosch SMI330 6-Axis IMU
> +
> +maintainers:
> + - Stefan Gutmann <stefam.gutmann@...bosch.com>
> +
> +description:
> + SMI330 is a 6-axis inertial measurement unit that supports acceleration and
> + gyroscopic measurements with hardware fifo buffering. Sensor also provides
> + events information such as motion, no-motion and tilt detection.
> +
> +properties:
> + compatible:
> + const: bosch,smi330
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: provide VDD power to the sensor.
> +
> + vddio-supply:
> + description: provide VDD IO power to the sensor.
> +
> + interrupts:
> + minItems: 1
> + maxItems: 2
> +
> + interrupt-names:
> + minItems: 1
> + maxItems: 2
> + items:
> + enum:
> + - INT1
> + - INT2
> +
> + drive-open-drain:
> + type: boolean
> + description:
> + set if the interrupt pin(s) should be configured as
> + open drain. If not set, defaults to push-pull.
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + // Example for I2C
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imu@68 {
> + compatible = "bosch,smi330";
> + reg = <0x68>;
> + vddio-supply = <&vddio>;
> + vdd-supply = <&vdd>;
> + interrupt-parent = <&gpio>;
> + interrupts = <26 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "INT1";
> + };
> + };
> +
> + // Example for SPI
> + #include <dt-bindings/interrupt-controller/irq.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imu@0 {
> + compatible = "bosch,smi330";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + interrupt-parent = <&gpio>;
> + interrupts = <26 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "INT1";
> + };
> + };
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists