[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251009-sycamore-blouse-ffa49a433f18@spud>
Date: Thu, 9 Oct 2025 18:01:51 +0100
From: Conor Dooley <conor@...nel.org>
To: Svyatoslav Ryhel <clamor95@...il.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Sowjanya Komatineni <skomatineni@...dia.com>,
Luca Ceresoli <luca.ceresoli@...tlin.com>,
Prashant Gaikwad <pgaikwad@...dia.com>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Mikko Perttunen <mperttunen@...dia.com>,
Linus Walleij <linus.walleij@...aro.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jonas Schwöbel <jonasschwoebel@...oo.de>,
Dmitry Osipenko <digetx@...il.com>,
Charan Pedumuru <charan.pedumuru@...il.com>,
Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>,
Aaron Kling <webgeek1234@...il.com>, Arnd Bergmann <arnd@...db.de>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, linux-clk@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v4 11/24] dt-bindings: display: tegra: document Tegra132
MIPI calibration device
On Thu, Oct 09, 2025 at 08:12:11AM +0300, Svyatoslav Ryhel wrote:
> чт, 9 жовт. 2025 р. о 00:14 Conor Dooley <conor@...nel.org> пише:
> >
> > On Wed, Oct 08, 2025 at 10:30:33AM +0300, Svyatoslav Ryhel wrote:
> > > Document MIPI calibration device found in Tegra132.
> >
> > Could you explain why a fallback is not suitable? The patchset is really
> > too big for me to trivially check that the change is correct.
>
> First of all, this compatible already exists in Linux kernel, I have
> just documented it to satisfy warnings. Secondly, each Tegra SoC
> generation has unique set of registers which should be configured.
> They all differ, hence fallback is not suitable here.
Okay, then put that in your commit message.
>
> > With an explanation,
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> >
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > > ---
> > > .../devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml
> > > index 193ddb105283..9a500f52f01d 100644
> > > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml
> > > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra114-mipi.yaml
> > > @@ -18,6 +18,7 @@ properties:
> > > enum:
> > > - nvidia,tegra114-mipi
> > > - nvidia,tegra124-mipi
> > > + - nvidia,tegra132-mipi
> > > - nvidia,tegra210-mipi
> > > - nvidia,tegra186-mipi
> > >
> > > --
> > > 2.48.1
> > >
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists