linux-kernel - Re: [PATCH] RDMA/uverbs: fix umem release in UVERBS_METHOD_CQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251009184854.GB14552@unreal>
Date: Thu, 9 Oct 2025 21:48:54 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Shuhao Fu <sfual@....ust.hk>
Cc: Jason Gunthorpe <jgg@...dia.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: fix umem release in UVERBS_METHOD_CQ_CREATE

On Fri, Oct 10, 2025 at 12:40:26AM +0800, Shuhao Fu wrote:
> In `UVERBS_METHOD_CQ_CREATE`, umem should be released if anything goes
> wrong. Currently, if `create_cq_umem` fails, umem would not be
> released or referenced, causing a possible leak.

It is only partially true. UMEM is released inside .create_cq_umem()
implementation. However there is an issue there that it doesn't release
in all flows. You need to change efa_create_cq_umem() too.

> 
> Fixes: 1a40c362ae26 ("RDMA/uverbs: Add a common way to create CQ with umem")
> Signed-off-by: Shuhao Fu <sfual@....ust.hk>
> ---
>  drivers/infiniband/core/uverbs_std_types_cq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/uverbs_std_types_cq.c b/drivers/infiniband/core/uverbs_std_types_cq.c
> index 37cd37556510..9344020dede1 100644
> --- a/drivers/infiniband/core/uverbs_std_types_cq.c
> +++ b/drivers/infiniband/core/uverbs_std_types_cq.c
> @@ -193,8 +193,10 @@ static int UVERBS_HANDLER(UVERBS_METHOD_CQ_CREATE)(
>  
>  	ret = umem ? ib_dev->ops.create_cq_umem(cq, &attr, umem, attrs) :
>  		ib_dev->ops.create_cq(cq, &attr, attrs);
> -	if (ret)
> +	if (ret) {
> +		ib_umem_release(umem);
>  		goto err_free;
> +	}
>  
>  	obj->uevent.uobject.object = cq;
>  	obj->uevent.uobject.user_handle = user_handle;
> -- 
> 2.39.5
> 
>