linux-kernel - Re: [PATCH 0/2] mfd: ls2kbmc: Fix a couple Smatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4_O=qoF9q+si59_L3bzo_8qZ4cdmXOwMtLSDxtdeg3Xg@mail.gmail.com>
Date: Thu, 9 Oct 2025 11:07:01 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Binbin Zhou <zhoubinbin@...ngson.cn>, Chong Qiao <qiaochong@...ngson.cn>, 
	Corey Minyard <corey@...yard.net>, Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] mfd: ls2kbmc: Fix a couple Smatch warnings

On Fri, Oct 3, 2025 at 5:29 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> These are two issues which were detected by Smatch.  They're not really
> going to happen in real life.  Small kmalloc()s can't fail.
> The devm_mfd_add_devices() function isn't going to fail either...
>
> But still, they're worth fixing just for correctness sake.
Reviewed-by: Huacai Chen <chenhuacai@...ngson.cn>
>
> Dan Carpenter (2):
>   mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()
>   mfd: ls2kbmc: check for devm_mfd_add_devices() failure
>
>  drivers/mfd/ls2k-bmc-core.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.51.0
>