linux-kernel - Re: [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDE2BDLEZHBW.253EO66P7ZH2P@kernel.org>
Date: Thu, 09 Oct 2025 22:09:42 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Mohamed Ahmed" <mohamedahmedegypt2001@...il.com>
Cc: <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>, "Mary
 Guillemard" <mary@...y.zone>, "Faith Ekstrand"
 <faith.ekstrand@...labora.com>, "Lyude Paul" <lyude@...hat.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>,
 <nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages

On Thu Oct 9, 2025 at 6:51 PM CEST, Mohamed Ahmed wrote:
>> Let's move the call to select_page_shift() into op_map_prepare().
>
> How would this work? Originally when we were working on this, we did
> place it in op_map_prepare() but we ran into the issue where
> nouveau_uvmm_vmm_put() needed the page_shift retrieved (see
> nouveau_uvmm_sm_prepare_unwind()).

-			ret = op_map_prepare(uvmm, &new->map, &op->map, args, PAGE_SHIFT);
+			ret = op_map_prepare(uvmm, &new->map, &op->map, args,
+					     select_page_shift(uvmm, &op->map));

You can move this call to select_page_shift() into op_map_prepare(), that's not
related to nouveau_uvmm_sm_prepare_unwind(), right?