[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a303c08d-f05d-41e5-932d-20bc96a17efd@intel.com>
Date: Thu, 9 Oct 2025 13:48:39 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>, Babu Moger <bmoger@....com>, "Babu
Moger" <babu.moger@....com>, "Dave.Martin@....com" <Dave.Martin@....com>,
"james.morse@....com" <james.morse@....com>, "tglx@...utronix.de"
<tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de"
<bp@...en8.de>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "x86@...nel.org" <x86@...nel.org>, "hpa@...or.com" <hpa@...or.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"peternewman@...gle.com" <peternewman@...gle.com>, "Eranian, Stephane"
<eranian@...gle.com>, "gautham.shenoy@....com" <gautham.shenoy@....com>
Subject: Re: [PATCH v2] x86/resctrl: Fix buggy overflow when reactivating
previously Unavailable RMID
Hi Tony,
On 10/9/25 11:39 AM, Luck, Tony wrote:
>> Here is what I do to check for non-ascii characters:
>> $ b4 am <message ID>
>> $ grep -P '[^\t\n\x20-\x7E]' <downloaded patch>
>>
>> Could you please try it out on this patch and fix the matches?
>
> Does the non-ascii rule include the cover letter? Or just the patches
> that will be applied and included into the Linux GIT repository?
>
> My AET patches are "clean", but the cover letter has some output
> from the tree(1) command. So the grep kicks out this:
>
> ├── mon_PERF_PKG_00
> │ ├── activity
> │ └── core_energy
> └── mon_PERF_PKG_01
> ├── activity
> └── core_energy
I think this is fine. I do not know if there is an official rule about this but in
this case the problem is the subtle differences in the text when it, like in
this changelog, switches between ascii and non-ascii for the "same" character.
For example, like when this changelog switches the quotes between "Unavailable" and
“Unavailable”. This is unnecessary obfuscation.
Reinette
Powered by blists - more mailing lists