linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6feb193-0d3d-4cbc-857b-7576db25e929@kernel.org>
Date: Thu, 9 Oct 2025 11:34:31 +0800
From: Chao Yu <chao@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>, brauner@...nel.org
Cc: chao@...nel.org, linux-kernel@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net, oe-lkp@...ts.linux.dev,
 oliver.sang@...el.com, linux-fsdevel@...r.kernel.org, josef@...icpanda.com,
 ltp@...ts.linux.it
Subject: Re: [f2fs-dev] [PATCH] f2fs: don't call iput() from f2fs_drop_inode()

On 10/1/2025 7:29 AM, Mateusz Guzik wrote:
> iput() calls the problematic routine, which does a ->i_count inc/dec
> cycle. Undoing it with iput() recurses into the problem.
> 
> Note f2fs should not be playing games with the refcount to begin with,
> but that will be handled later. Right now solve the immediate
> regression.
> 
> Fixes: bc986b1d756482a ("fs: stop accessing ->i_count directly in f2fs and gfs2")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202509301450.138b448f-lkp@intel.com
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,