linux-kernel - Re: smb: client: Simplify a return statement in get_smb2_acl_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bc8f02de-0cd5-475d-bb19-e44e202f7a58@web.de>
Date: Thu, 9 Oct 2025 07:17:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Steve French <smfrench@...il.com>, linux-cifs@...r.kernel.org,
 samba-technical <samba-technical@...ts.samba.org>,
 Bharath SM <bharathsm@...rosoft.com>, Paulo Alcantara <pc@...guebit.org>,
 Ronnie Sahlberg <ronniesahlberg@...il.com>,
 Shyam Prasad N <sprasad@...rosoft.com>, Tom Talpey <tom@...pey.com>
Cc: Steve French <sfrench@...ba.org>, LKML <linux-kernel@...r.kernel.org>,
 kernel-janitors@...r.kernel.org
Subject: Re: smb: client: Simplify a return statement in
 get_smb2_acl_by_path()

> This is an example of one that is probably slightly worth it,

Thanks for such a positive indication.


> it shrinks one line of code, and also doesn't have risk,

Similar source code refinements might become also interesting and helpful.


> but at least three of the others today don't shrink and sometimes grow lines of code (and don't fix anything )

Further update candidates can be found and eventually transformed also with the help
of the semantic patch language (Coccinelle software).


> so are unlikely to be worth it since they slightly increase risk of adding difficulty to stable backports of future fixes

I hope that such change resistance can be reconsidered.

Regards,
Markus