linux-kernel - Re: [PATCH v2] virtio_vdpa: fix misleading return in void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEux7-Xe3PrGpneJ3ynowEjYnEjxB5f+OV9RWvS-aRfy0w@mail.gmail.com>
Date: Thu, 9 Oct 2025 13:38:05 +0800
From: Jason Wang <jasowang@...hat.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: eperezma@...hat.com, mst@...hat.com, xuanzhuo@...ux.alibaba.com, 
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] virtio_vdpa: fix misleading return in void function

On Mon, Oct 6, 2025 at 2:12 AM Alok Tiwari <alok.a.tiwari@...cle.com> wrote:
>
> virtio_vdpa_set_status() is declared as returning void, but it used
> "return vdpa_set_status()" Since vdpa_set_status() also returns
> void, the return statement is unnecessary and misleading.
> Remove it.
>
> Fixes: c043b4a8cf3b ("virtio: introduce a vDPA based transport")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
> v1 -> v2
> added fixes tag
> ---
>  drivers/virtio/virtio_vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 657b07a60788..1abecaf76465 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -80,7 +80,7 @@ static void virtio_vdpa_set_status(struct virtio_device *vdev, u8 status)
>  {
>         struct vdpa_device *vdpa = vd_get_vdpa(vdev);
>
> -       return vdpa_set_status(vdpa, status);
> +       vdpa_set_status(vdpa, status);
>  }
>
>  static void virtio_vdpa_reset(struct virtio_device *vdev)
> --
> 2.50.1
>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks