linux-kernel - Re: [PATCH] powerpc, ocxl: Fix extraction of struct xive_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19ffe9eeb8703656285cab6f0d819602860bb28b.camel@linux.ibm.com>
Date: Thu, 09 Oct 2025 11:40:55 +1100
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Nam Cao <namcao@...utronix.de>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Michael
 Ellerman <mpe@...erman.id.au>,
        Christophe Leroy	
 <christophe.leroy@...roup.eu>,
        Frederic Barrat <fbarrat@...ux.ibm.com>
Cc: Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman	
 <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>, linuxppc-dev@...ts.ozlabs.org,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Ritesh Harjani (IBM)"	
 <ritesh.list@...il.com>
Subject: Re: [PATCH] powerpc, ocxl: Fix extraction of struct xive_irq_data

On Wed, 2025-10-08 at 08:13 +0000, Nam Cao wrote:
> Commit cc0cc23babc9 ("powerpc/xive: Untangle xive from child interrupt
> controller drivers") changed xive_irq_data to be stashed to chip_data
> instead of handler_data. However, multiple places are still attempting to
> read xive_irq_data from handler_data and get a NULL pointer deference bug.
> 
> Update them to read xive_irq_data from chip_data.
> 
> Non-XIVE files which touch xive_irq_data seem quite strange to me,
> especially the ocxl driver. I think there ought to be an alternative
> platform-independent solution, instead of touching XIVE's data directly.
> Therefore, I think this whole thing should be cleaned up. But perhaps I
> just misunderstand something. In any case, this cleanup would not be
> trivial; for now, just get things working again.

ocxl has always done quite a few weird things...

> 
> Fixes: cc0cc23babc9 ("powerpc/xive: Untangle xive from child interrupt
> controller drivers")
> Reported-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
> Closes:
> https://lore.kernel.org/linuxppc-dev/68e48df8.170a0220.4b4b0.217d@mx.google.com/
> Signed-off-by: Nam Cao <namcao@...utronix.de>

Acked-by: Andrew Donnellan <ajd@...ux.ibm.com>  # ocxl

> ---
> VAS and OCXL has not been tested. I noticed them while grepping.

Unfortunately I don't have convenient ocxl hardware on hand to test with any
more (I'm sure the cards are floating around *somewhere* in the company...), but
this looks like a straightforward change.

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited