linux-kernel - Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d00ed57-3c74-492e-83ae-88ca1ce98311@kernel.org>
Date: Thu, 9 Oct 2025 07:54:19 +0200
From: Jiri Slaby <jirislaby@...nel.org>
To: Timothy Pearson <tpearson@...torengineering.com>
Cc: linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 linux-pci <linux-pci@...r.kernel.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>,
 christophe leroy <christophe.leroy@...roup.eu>,
 Naveen N Rao <naveen@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Shawn Anastasio <sanastasio@...torengineering.com>
Subject: Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot
 allocator

On 09. 10. 25, 3:24, Timothy Pearson wrote:
> A highly unlikely NULL dereference in the allocation error handling path was
> introduced in 466861909255.  Avoid dereferencing php_slot->bus by using
> dev_warn() instead of SLOT_WARN() in the error path.
> 
> Fixes: 466861909255 ("PCI: pnv_php: Clean up allocated IRQs on unplug")
> Signed-off-by: Timothy Pearson <tpearson@...torengineering.com>

LGTM, perhaps also a lnk to the report:
Link: 
https://lore.kernel.org/all/304758063.1694752.1757427687463.JavaMail.zimbra@raptorengineeringinc.com/


Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

thanks,
-- 
js
suse labs