linux-kernel - Re: [PATCH v2 12/13] ext4: add large folios support for moving extents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eec9bf55-3e16-446e-8f80-2556a7ec4172@huaweicloud.com>
Date: Thu, 9 Oct 2025 15:23:37 +0800
From: Zhang Yi <yi.zhang@...weicloud.com>
To: Jan Kara <jack@...e.cz>
Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca,
 yi.zhang@...wei.com, libaokun1@...wei.com, yukuai3@...wei.com,
 yangerkun@...wei.com
Subject: Re: [PATCH v2 12/13] ext4: add large folios support for moving
 extents

On 10/8/2025 8:53 PM, Jan Kara wrote:
> On Thu 25-09-25 17:26:08, Zhang Yi wrote:
>> From: Zhang Yi <yi.zhang@...wei.com>
>>
>> Pass the moving extent length into mext_folio_double_lock() so that it
>> can acquire a higher-order folio if the length exceeds PAGE_SIZE. This
>> can speed up extent moving when the extent is larger than one page.
>> Additionally, remove the unnecessary comments from
>> mext_folio_double_lock().
>>
>> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>
> 
> One nit below, otherwise feel free to add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
>> @@ -214,7 +206,8 @@ static int mext_move_begin(struct mext_data *mext, struct folio *folio[2],
>>  	orig_pos = ((loff_t)mext->orig_map.m_lblk) << blkbits;
>>  	donor_pos = ((loff_t)mext->donor_lblk) << blkbits;
>>  	ret = mext_folio_double_lock(orig_inode, donor_inode,
>> -			orig_pos >> PAGE_SHIFT, donor_pos >> PAGE_SHIFT, folio);
>> +			orig_pos >> PAGE_SHIFT, donor_pos >> PAGE_SHIFT,
>> +			mext->orig_map.m_len << blkbits, folio);
> 			^^^ This is just cosmetical but we should cast to
>   size_t before the shift...
> 
> 								Honza

Ha, right! I missed this, thank you for pointing it out, will fix in
next iteration.

Best Regards,
Yi.