linux-kernel - [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251009010903.1323979-1-aashish@aashishsharma.net>
Date: Wed,  8 Oct 2025 18:09:03 -0700
From: Aashish Sharma <aashish@...hishsharma.net>
To: Vineeth Pillai <vineeth@...byteword.org>,
	Lu Baolu <baolu.lu@...ux.intel.com>,
	Dmytro Maluka <dmaluka@...gle.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Joerg Roedel <joro@...tes.org>,
	Tina Zhang <tina.zhang@...el.com>
Cc: Robin Murphy <robin.murphy@....com>,
	iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Aashish Sharma <shraash@...gle.com>,
	Aashish Sharma <aashish@...hishsharma.net>
Subject: [PATCH] iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb

Invalidation hint (ih) in the function 'qi_desc_iotlb' is
initialized to zero and never used. It is embedded in the 0th bit
of the 'addr' parameter. Get the correct 'ih' value from there.

Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
Signed-off-by: Aashish Sharma <aashish@...hishsharma.net>
---
 drivers/iommu/intel/iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.h b/drivers/iommu/intel/iommu.h
index 3056583d7f56..dcc5466d35f9 100644
--- a/drivers/iommu/intel/iommu.h
+++ b/drivers/iommu/intel/iommu.h
@@ -1097,7 +1097,7 @@ static inline void qi_desc_iotlb(struct intel_iommu *iommu, u16 did, u64 addr,
 				 struct qi_desc *desc)
 {
 	u8 dw = 0, dr = 0;
-	int ih = 0;
+	int ih = addr & 1;
 
 	if (cap_write_drain(iommu->cap))
 		dw = 1;
-- 
2.51.0.710.ga91ca5db03-goog