lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMRc=Me6cRLPsz9-DLMyFXVn8AXExWRP4fwHaN3=8HuHR6+VGg@mail.gmail.com>
Date: Thu, 9 Oct 2025 12:06:59 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Stefano Manni <stefano.manni@...il.com>
Cc: linus.walleij@...aro.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] gpio: pisosr: read ngpios as U32

On Wed, Oct 8, 2025 at 11:28 PM Stefano Manni <stefano.manni@...il.com> wrote:
>
>
>
> On lun, ago 11 2025 at 09:56:51 +02:00:00, Bartosz Golaszewski
> <brgl@...ev.pl> wrote:
> > On Wed, Aug 6, 2025 at 9:17 AM Stefano Manni
> > <stefano.manni@...il.com> wrote:
> >>
> >>  If of_property_read_u16() is used instead the value read
> >>  is always zero.
> >>
> >
> > Please state more clearly what the problem is. This sentence is quite
> > garbled,
>
>
> the value returned by of_property_read_u16() is always zero, if
> of_property_read_u32()
> is used instead , then the returned value is the right one contained in
> the dts.
>

So please put this into the commit message.

> >
> > If you're touching this, can you switch to using generic device
> > properties instead?
> >
>
> what do you mean with "generic device properties"?
>

Functions that allow to read properties through the fwnode associated
with a device bound to a driver. In this case:
device_property_read_u32().

Bart

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ