[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025100959-denture-freebie-76b4@gregkh>
Date: Thu, 9 Oct 2025 12:49:06 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Matthew Schwartz <matthew.schwartz@...ux.dev>
Cc: harry.wentland@....com, Christian.Koenig@....com, sunpeng.li@....com,
airlied@...il.com, simona@...ll.ch, Alexander.Deucher@....com,
linux-kernel@...r.kernel.org, mario.limonciello@....com,
amd-gfx@...ts.freedesktop.org, stable@...r.kernel.org,
regressions@...ts.linux.dev
Subject: Re: [PATCH] Revert "drm/amd/display: Only restore backlight after
amdgpu_dm_init or dm_resume"
On Thu, Oct 09, 2025 at 12:00:29PM +0200, Matthew Schwartz wrote:
>
> >
> > On Oct 9, 2025, at 11:51 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, Oct 09, 2025 at 11:23:01AM +0200, Matthew Schwartz wrote:
> >> This fix regressed the original issue that commit d83c747a1225
> >> ("drm/amd/display: Fix brightness level not retained over reboot") solved,
> >> so revert it until a different approach to solve the regression that
> >> it caused with AMD_PRIVATE_COLOR is found.
> >>
> >> Fixes: a490c8d77d50 ("drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume")
> >> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4620
> >> Signed-off-by: Matthew Schwartz <matthew.schwartz@...ux.dev>
> >> ---
> >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++--------
> >> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 -------
> >> 2 files changed, 4 insertions(+), 15 deletions(-)
> >
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read:
> > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
>
> Apologies, I was a bit confused by:
>
> If a regression made it into a proper mainline release during the past twelve months, ensure to tag the fix with “Cc: stable@...r.kernel.org”
>
> in the regressions page, but I see now the way I did it via email cc was incorrect.
>
> Should I resend with that fixed?
Please do.
thanks!
greg k-h
Powered by blists - more mailing lists