linux-kernel - Re: [PATCH v2 11/15] blktrace: add block trace commands for zone operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <99edea66-957c-4804-97e3-c88b615e54f0@wdc.com>
Date: Thu, 9 Oct 2025 11:17:21 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: hch <hch@....de>
CC: Jens Axboe <axboe@...nel.dk>, Steven Rostedt <rostedt@...dmis.org>, Masami
 Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
	<mathieu.desnoyers@...icios.com>, "linux-block@...r.kernel.org"
	<linux-block@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-trace-kernel@...r.kernel.org"
	<linux-trace-kernel@...r.kernel.org>, "linux-btrace@...r.kernel.org"
	<linux-btrace@...r.kernel.org>, John Garry <john.g.garry@...cle.com>, Hannes
 Reinecke <hare@...e.de>, Damien Le Moal <dlemoal@...nel.org>, Naohiro Aota
	<Naohiro.Aota@....com>, Shinichiro Kawasaki <shinichiro.kawasaki@....com>,
	Chaitanya Kulkarni <chaitanyak@...dia.com>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH v2 11/15] blktrace: add block trace commands for zone
 operations

On 10/8/25 8:14 AM, hch wrote:
> On Tue, Oct 07, 2025 at 01:08:00PM +0000, Johannes Thumshirn wrote:
>> Sure for the old commands everything is still in the lower 32bits, this
>> has the nice property that we don't need to duplicate all the code for
>> v1 and v2.
> I don't think you need to duplicate anything, just have a little
> function that maps from the free-form v2 commands and flags to the
> v1 field.  Preferably including a mapping of all unsupported ones to
> a catchall unsupported command and flag each to indicate that the
> trace includes something only visible with v2.

So I've tried making a translation function (which is the trivial part) 
but then it's a game of whack-a-mole to unbreak compilation, ftrace, etc..

I think it's not really worth the effort.