linux-kernel - Re: [PATCH] dt-bindings: leds: bcm6358: Convert to DT Schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251009115339.2340708-1-hcarter@thegoodpenguin.co.uk>
Date: Thu,  9 Oct 2025 12:53:39 +0100
From: Harrison Carter <hcarter@...goodpenguin.co.uk>
To: robh@...nel.org
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	hcarter@...goodpenguin.co.uk,
	jonas.gorski@...il.com,
	krzk+dt@...nel.org,
	lee@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org,
	pavel@...nel.org
Subject: Re: [PATCH] dt-bindings: leds: bcm6358: Convert to DT Schema

Hi Rob,

Thanks for looking at my patch. There's an issue in the patch anyway that's 
been noticed between the patternProperties's regex and the names of the 
led nodes. Here it's just led@... but the nodes are named thing_colour.

On and off this regex has been done as .*_.*@, led@, and .*@ . What is the 
preference? led@ would amend the led information to a label in the node. The 
latter option is very promiscuous (but not uncommon in bindings), the former 
sticks to what the examples are sort of expecting.

Cheers,

HarryC