linux-kernel - Re: [PATCH v3 2/3] drm/bridge: Add ITE IT61620 MIPI DSI to HDMI bridge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <088cbc524dbb05757f244a6c7f26f3228e554f61@intel.com>
Date: Thu, 09 Oct 2025 15:48:54 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Pet Weng <pet.weng@....com.tw>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss
 <rfoss@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec
 <jernej.skrabec@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Hermes Wu <hermes.Wu@....com.tw>, Kenneth
 Hung <kenneth.Hung@....com.tw>, Pet Weng <pet.weng@....com.tw>, Pin-yen Lin
 <treapking@...gle.com>
Subject: Re: [PATCH v3 2/3] drm/bridge: Add ITE IT61620 MIPI DSI to HDMI
 bridge driver

On Thu, 09 Oct 2025, Pet Weng <pet.weng@....com.tw> wrote:
> +static void it61620_set_capability_from_edid_parse(struct it61620 *it61620,
> +						   const struct edid *edid)
> +{
> +	struct drm_device *drm = it61620->drm;
> +
> +	it61620->is_hdmi = drm_detect_hdmi_monitor(edid);
> +	it61620->en_audio = drm_detect_monitor_audio(edid);

Please don't add new users of drm_detect_monitor_audio() or
drm_detect_hdmi_monitor(). They're basically deprecated.

Use drm_edid_connector_update() and you can get at the same info via
connector->display_info.{is_hdmi,has_audio} members.

> +
> +	drm_dbg(drm, "%s mode, monitor %ssupport audio",
> +		it61620->is_hdmi ? "HDMI" : "DVI",
> +		it61620->en_audio ? "" : "not ");
> +}

> +static const struct drm_edid *it61620_bridge_edid_read(struct drm_bridge *bridge,
> +						       struct drm_connector *connector)
> +{
> +	struct it61620 *it61620 = bridge_to_it61620(bridge);
> +	struct device *dev = it61620->dev;
> +	const struct drm_edid *cached_edid;
> +
> +	cached_edid = drm_edid_read_custom(connector, it61620_get_edid_block,
> +					   it61620);
> +
> +	if (!cached_edid) {
> +		dev_dbg(dev, "failed to get edid!");
> +		return NULL;
> +	}
> +
> +	it61620_set_capability_from_edid_parse(it61620,
> +					       drm_edid_raw(cached_edid));

Please don't add new users of drm_edid_raw(). It's for transitioning
from struct edid to struct drm_edid only, and you should not add new
uses of struct edid either.

BR,
Jani.

> +	return cached_edid;
> +}

-- 
Jani Nikula, Intel