linux-kernel - Re: [RFC 2/2] vduse: lift restriction about net devices with CVQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a7f72cd-4418-4a15-bf68-caa157875d64@redhat.com>
Date: Thu, 9 Oct 2025 15:14:59 +0200
From: Maxime Coquelin <maxime.coquelin@...hat.com>
To: Eugenio Pérez <eperezma@...hat.com>, mst@...hat.com
Cc: Yongji Xie <xieyongji@...edance.com>, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Maxime Coquelin <mcoqueli@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Dragos Tatulea DE <dtatulea@...dia.com>, jasowang@...hat.com
Subject: Re: [RFC 2/2] vduse: lift restriction about net devices with CVQ



On 10/7/25 3:06 PM, Eugenio Pérez wrote:
> Now that the virtio_net driver is able to recover from a stall
> virtqueue, let's lift the restriction.
> 
> Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
> ---
>   drivers/vdpa/vdpa_user/vduse_dev.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index e7bced0b5542..95d2b898171d 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -1726,9 +1726,6 @@ static bool features_is_valid(struct vduse_dev_config *config)
>   	if ((config->device_id == VIRTIO_ID_BLOCK) &&
>   			(config->features & BIT_ULL(VIRTIO_BLK_F_CONFIG_WCE)))
>   		return false;
> -	else if ((config->device_id == VIRTIO_ID_NET) &&
> -			(config->features & BIT_ULL(VIRTIO_NET_F_CTRL_VQ)))
> -		return false;
>   
>   	if ((config->device_id == VIRTIO_ID_NET) &&
>   			!(config->features & BIT_ULL(VIRTIO_F_VERSION_1)))

I wonder whether the API version should be increased, otherwise I don't
see how the app creating the VDUSE device knows whether it can safely
advertises the CVQ support (except without doing trial and error).