linux-kernel - Re: [PATCH v3 1/3] dt-binding: display: Add ITE IT61620 MIPI DSI to HDMI bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cad5f48b-5992-4e29-8ca1-57535dfe3251@kernel.org>
Date: Thu, 9 Oct 2025 23:14:16 +0900
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pet Weng <pet.weng@....com.tw>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Hermes Wu <hermes.Wu@....com.tw>,
 Kenneth Hung <kenneth.Hung@....com.tw>, Pin-yen Lin <treapking@...gle.com>
Subject: Re: [PATCH v3 1/3] dt-binding: display: Add ITE IT61620 MIPI DSI to
 HDMI bridge

On 09/10/2025 23:13, Krzysztof Kozlowski wrote:
> On 09/10/2025 17:02, Pet Weng wrote:
>> +  The HDMI transmitter side supports up to 4Kx2K@...z resolutions, and is
>> +  compliant with HDMI 1.4b and HDCP 1.4.
>> +
>> +  For audio, the IT61620 supports up to 8-channel LPCM via I2S (multi-line or
>> +  TDM mode), with optional S/PDIF or DSD (for SACD). It supports audio
>> +  sampling rates up to 192kHz.
>> +
>> +allOf:
>> +  - $ref: /schemas/sound/dai-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: ite,it61620
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +    description: interrupt specifier of INT pin
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +    description: GPIO specifier of RESET pin
> 
> 
> If you are going to send new version: drop description, pretty
> redundant. Cannot be anything else.
> 
>> +
>> +  ivdd-supply:
>> +    description: core voltage
>> +
>> +  ovdd-supply:
>> +    description: I/O voltage
>> +
>> +  ovdd1833-supply:
>> +    description: flexible I/O votage
>> +
>> +  pinctrl-names:
>> +    items:
>> +      - const: default
>> +
>> +  pinctrl-0:
>> +    maxItems: 1
> 
> 
> Both pinctrl properties are usually redundant here. Does your driver
> actually require them?

And now I checked and I do not see direct usage in the driver or did I
miss something?

Best regards,
Krzysztof